Revert password field selection using shortcut #4451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change introduced in [PR#4437](#4437) caused more new problems, and was trying to fix problem that happened just once. Somehow, even keypresses are correct, we do not type password correctly. So I remove change to select password field and use tab key instead. I was not able to reproduce exactly same issue, when password is typed only once.
|
Would love to see this fixed, as it currently blocks allso stagings (plus prod test) |
|
merged as requested by @andreasstieger and @DimStar77 but I suggest @rwx788 to still take a look how to proceed. I retriggered the staging tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of original #4448 (with passing ci)
Change introduced in
PR#4437
caused more new problems, and was trying to fix problem that happened
just once. Somehow, even keypresses are correct, we do not type password
correctly. So I remove change to select password field and use tab key
instead. I was not able to reproduce exactly same issue, when password
is typed only once.
Verification runs (from #4448)
http://g226.suse.de/tests/829
http://g226.suse.de/tests/828