Wait longer to show install overview in upgrade #4580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Mar 11, 2018
| assert_screen "installation-settings-overview-loaded"; | ||
| # During upgrade, it takes longer time to check package dependencies, | ||
| # especially with multiple addons selected | ||
| my $timeout = get_var('UPGRADE') ? 60 + 30 * (scalar split(/,/, get_var('SCC_ADDONS', get_var('ADDONS', get_var('ADDONURL', ''))))) : undef; |
There was a problem hiding this comment.
I'm not sure if we need such a complicated structure here, it should be fine to increase timeout to some acceptable max value.
There was a problem hiding this comment.
Yes, I just didn't want to change the default timeout of installation.
Simply set timeout to 150s, since 130s is required at worst case observed.
In upgrade, it takes longer time to check package dependencies before system is ready to upgrade. And even longer time is required if multiple addons are selected during upgrade. - poo#31552
QingmingSu
force-pushed
the
sle15_upgrade
branch
from
106fabe
to
cc80640
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In upgrade, it takes longer time to check package
dependencies before system is ready to upgrade. And
even longer time is required if multiple addons are
selected during upgrade.
Many tests failed with this issue on o.s.d, such as:
https://openqa.suse.de/tests/1526008
https://openqa.suse.de/tests/1526165
https://openqa.suse.de/tests/1526200
It took ~130s at worst case.