Fix virtualization role tests for firewall disabled #4609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Mar 14, 2018
lib/main_common.pm
Outdated
| @@ -963,7 +963,7 @@ sub load_consoletests { | |||
| } | |||
| loadtest "console/vim" if is_opensuse || !sle_version_at_least('15') || !get_var('PATTERNS') || check_var_array('PATTERNS', 'enhanced_base'); | |||
| # textmode install comes without firewall by default atm on openSUSE | |||
| if ((is_sle || !check_var("DESKTOP", "textmode")) && !is_staging() && !is_krypton_argon) { | |||
| if ((is_sle || !check_var("DESKTOP", "textmode")) && !is_staging() && !is_krypton_argon && !is_virtualization_server) { | |||
There was a problem hiding this comment.
Could you please reference the fate issue - there was one, right? - that describes why this is the case?
There was a problem hiding this comment.
Added to the description.
There was a problem hiding this comment.
Sorry, I mean add as a comment in the source code
jknphy
force-pushed
the
fix_firewall_virtualization_roles
branch
from
8346db8
to
490b830
Compare
jknphy
force-pushed
the
fix_firewall_virtualization_roles
branch
from
490b830
to
581ea68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unschedule test firewall_enabled and avoid to stop firewall in sshd test for virtualization server kvm or xen.