Implement system role selection without shortcut usage #4674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why again do you mention that there is no scenario where a "non-default" role is selected when you mention textmode+kvm_server_role? |
okurz
reviewed
Mar 21, 2018
tests/installation/system_role.pm
Outdated
| @@ -26,8 +27,22 @@ my %role_hotkey = ( | |||
|
|
|||
| sub change_system_role { | |||
| my ($system_role) = @_; | |||
| send_key 'alt-' . $role_hotkey{$system_role}; | |||
| assert_screen "system-role-$system_role-selected"; | |||
| # Since SLE 15 do not have shortcuts for system roles anymore | |||
As a result of [bsc#1084674](https://bugzilla.suse.com/show_bug.cgi?id=1084674), now we cannot use shortkeys to select system role. Hence, click in case of x11 installation and using navigation keys for ncurses. See [poo#33562](https://progress.opensuse.org/issues/33562).
rwx788
force-pushed
the
33562_system_roles
branch
from
c58269f
to
79bf202
Compare
|
@okurz all points fixed, I'll merge once travis is done ;) |
|
@rwx788 when you merge this PR, could you also merge this MR: https://gitlab.suse.de/openqa/os-autoinst-needles-sles/merge_requests/780 If you want I can merge your needles as well. :) (NVM ... they're already merged) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of bsc#1084674,
now we cannot use shortkeys to select system role.
Hence, click in case of x11 installation and using navigation keys for ncurses.
See poo#33562.