Add default modules for SLES15 media migration #4753

Jiawei517 · 2018-04-03T10:12:59Z

Add follow modules for SLES12SPx&SLSE11 to SLES15 migration
SLE-Product-SLES15
SLE-Module-Basesystem15
SLE-Module-Containers15
SLE-Module-Desktop-Applications15
SLE-Module-Legacy15
SLE-Module-Server-Applications15
SLE-Module-Web-Scripting15

See poo#34021
Related ticket: https://progress.opensuse.org/issues/34021
Verification run: http://10.67.17.147/tests/2256

dehai · 2018-04-04T02:09:04Z

tests/installation/addon_products_sle.pm

@@ -15,7 +15,7 @@ use strict;
 use base "y2logsstep";
 use testapi;
 use utils 'addon_license';
-use version_utils 'is_sle';
+use version_utils qw/is_sle sle_version_at_least/;


should be use qw(A B) format, the same as line 54

QingmingSu · 2018-04-04T06:21:26Z

tests/installation/addon_products_sle.pm

@@ -43,6 +43,19 @@ sub handle_all_packages_medium {
    # The legacy module is required if upgrade from previous version (bsc#1066338)
    push @addons, 'legacy' if get_var('UPGRADE') && !grep(/^legacy$/, @addons);

+    # For SLES12SPx and SLES11SPx to SLES15 migration, follow modules are need at least


Should we restrict the change to SLES? Otherwise the media upgrade should be failed for SLED 12-SP3 -> 15

add sled check in line 53

QingmingSu · 2018-04-04T06:26:07Z

tests/installation/addon_products_sle.pm

+    # SLE-Module-Server-Applications15
+    # SLE-Module-Web-Scripting15
+    if (get_var('UPGRADE') && !sle_version_at_least('15', version_variable => 'HDDVERSION')) {
+        my @default_addon = qw/contm desktop legacy serverapp script/;


The variable name "default_addon" is some bit confusing, here you try to define a list of modules which are required to upgrade SLE 11/12 to 15. Please think about it.

QingmingSu · 2018-04-04T06:27:13Z

tests/installation/addon_products_sle.pm

+    # SLE-Module-Legacy15
+    # SLE-Module-Server-Applications15
+    # SLE-Module-Web-Scripting15
+    if (get_var('UPGRADE') && !sle_version_at_least('15', version_variable => 'HDDVERSION')) {


Seems sle_version_at_least is already deprecated, is there another way to do this check?

is_sle doesn't support setup version_variable, such as version_variable => 'HDDVERSION'.
I suppose update is_sle is a better solution for it.

okurz · 2018-04-08T16:25:08Z

tests/installation/addon_products_sle.pm

+    # SLE-Module-Legacy15
+    # SLE-Module-Server-Applications15
+    # SLE-Module-Web-Scripting15
+    if (get_var('UPGRADE') && !sle_version_at_least('15', version_variable => 'HDDVERSION') && !check_var('SLE_PRODUCT', 'sled')) {


@ldevulder @alvarocarvajald @asmorodskyi comments on this? Specifically the latest portion about !sled, maybe the same applies for other products?

hard to say , it's related to upgrade only. and I have no information about SLE 12 SP3 with HPC module to SLE 15 HPC upgrade . what modules should / may be selected there. Not saying that it is normal , just stating the fact. And based on this statement - I am ok with this PR

For sles4sap we need base,desktop,serverapp,sapapp,ha, but currently we don't have migration tests in place in o.s.d., so its inclusion into this part of the code can wait for the time being ... but if you don't mind adding it now, it will helps us in the long run.

Same as @alvarocarvajald for HA, no upgrade tests in o.s.d. at this time. Should be added in the future.

ok then we can keep it as is, no over-engineering without any tests

No upgrade test for sles4sap product yet.
But HA extension is already covered in migration testing, for example:
media_upgrade_sles11sp4+ha+geo@64bit : https://openqa.suse.de/tests/1604474
media_upgrade_sles12sp3+ha+geo_allpatterns@64bit : https://openqa.suse.de/tests/1604110
proxyscc_upgrade_sles12sp3+ha+geo@64bit : https://openqa.suse.de/tests/1604102

You can find more upgrade tests for HA in SLE 15 job groups:
https://openqa.suse.de/group_overview/111
https://openqa.suse.de/group_overview/145

@QingmingSu, thx! I will try to re-use these tests. The only think I have to do is to publish a HDD from these tests to after re-use it with all the HA stack tests.

okurz · 2018-04-10T07:16:51Z

tests/installation/addon_products_sle.pm

+    # SLE-Module-Desktop-Applications15
+    # SLE-Module-Legacy15
+    # SLE-Module-Server-Applications15
+    # SLE-Module-Web-Scripting15


I suggest to not spell out the modules in a comment. If the situation will change the list below will change but I fear someone will forget to update the comments. I suggest to remove this list from the comment

okurz · 2018-04-10T07:17:38Z

tests/installation/addon_products_sle.pm

+    # SLE-Module-Server-Applications15
+    # SLE-Module-Web-Scripting15
+    if (get_var('UPGRADE') && !sle_version_at_least('15', version_variable => 'HDDVERSION') && !check_var('SLE_PRODUCT', 'sled')) {
+        my @demand_addon = qw(contm desktop legacy serverapp script);


I wonder if this is a good place to define (yet another) list of modules. Should we maybe put all lists together in products/sle/main.pm ?

I agree we should define a list for all modules. But in this case, firstly those domand module is only be needed for media migration, it is not a common list for all prodcut upgrade. And secondly this list should be a tempory one, we don't have a fixed list for sles15 media migraion right now. So I suppose we can add it here for now,.

Add follow modules for SLES12SP&SLSE11 to SLES15 migration SLE-Product-SLES15 SLE-Module-Basesystem15 SLE-Module-Containers15 SLE-Module-Desktop-Applications15 SLE-Module-Legacy15 SLE-Module-Server-Applications15 SLE-Module-Web-Scripting15 -see poo#34021

okurz · 2018-04-11T19:32:44Z

ok, let's go ahead with it. The extension of is_sle is something that would be appreciated for the future

Jiawei517 force-pushed the master branch from 4aadfda to 566c074 Compare April 3, 2018 10:18

dehai reviewed Apr 4, 2018

View reviewed changes

QingmingSu reviewed Apr 4, 2018

View reviewed changes

Jiawei517 force-pushed the master branch from 566c074 to 6745f38 Compare April 8, 2018 03:49

okurz reviewed Apr 8, 2018

View reviewed changes

okurz reviewed Apr 10, 2018

View reviewed changes

Jiawei517 force-pushed the master branch from 6745f38 to a49d786 Compare April 11, 2018 01:09

Jiawei517 force-pushed the master branch from a49d786 to 4a9b59e Compare April 11, 2018 09:40

okurz merged commit 0df591b into os-autoinst:master Apr 11, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add default modules for SLES15 media migration #4753

Add default modules for SLES15 media migration #4753

Jiawei517 commented Apr 3, 2018 •

edited

dehai Apr 4, 2018

QingmingSu Apr 4, 2018

Jiawei517 Apr 8, 2018

QingmingSu Apr 4, 2018

QingmingSu Apr 4, 2018

Jiawei517 Apr 8, 2018 •

edited

okurz Apr 8, 2018

asmorodskyi Apr 9, 2018

alvarocarvajald Apr 9, 2018

ldevulder Apr 9, 2018

okurz Apr 10, 2018

QingmingSu Apr 10, 2018

ldevulder Apr 10, 2018

okurz Apr 10, 2018

okurz Apr 10, 2018

Jiawei517 Apr 11, 2018

okurz commented Apr 11, 2018

Add default modules for SLES15 media migration #4753

Add default modules for SLES15 media migration #4753

Conversation

Jiawei517 commented Apr 3, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Jiawei517 Apr 8, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

okurz commented Apr 11, 2018

Jiawei517 commented Apr 3, 2018 •

edited

Jiawei517 Apr 8, 2018 •

edited