Multiple fixes for partitioning_warnings #4803
Conversation
rwx788
force-pushed
the
34498_btrfs_warnings
branch
4 times, most recently
from
0598e26
to
bdde18b
Compare
|
Workers fail all the time, so 2 scenarios are not fully covered, but we can see if it breaks on production. So I remove WIP label. |
|
needles merged |
| } | ||
| } | ||
|
|
||
| sub post_fail_hook { } |
There was a problem hiding this comment.
I have something very cool for you -> https://github.com/os-autoinst/os-autoinst/blame/master/doc/backend_vars.asciidoc#L11 :)
Please remove this post fail hook overwrite from this PR, then LGTM -> merge
There was a problem hiding this comment.
Good to know. Test fails on SLE12 on power, seems that behavior is different there. Will fix that first.
So, we now can check warning if partition is too small to handle snapshots. On power test is currently failing due to too big prep boot partition. See [poo#34498](https://progress.opensuse.org/issues/34498).
rwx788
force-pushed
the
34498_btrfs_warnings
branch
from
bdde18b
to
fef7005
Compare
|
Missing needle for aarch64 can be found here: |
| sub process_missing_special_partitions { | ||
| # Have missing boot/zipl partition warning only in storage_ng | ||
| if (is_storage_ng && check_var('ARCH', 's390x')) { # s390x needs /boot/zipl on ext partition | ||
| process_warning(warning => 'no-boot-zipl', key => 'alt-n'); |
There was a problem hiding this comment.
from this PR looks like alt-n should be default option , I see here more calls with alt-n then with alt-y. But feel free to ignore this comment
There was a problem hiding this comment.
That's true. I will leave it for now, only because by default we proceed with the installation acknowledging that we know what we are doing and with No, it will bring us back to expert partitioner.
|
LGTM , but I can't merge needles currently |
Fixing regression introduced in os-autoinst#4803, pressed No in one of the warnings, so got back to the expert partitioner. This only affected s390x and x86 as we don't have special warnings there. See [poo#34498](https://progress.opensuse.org/issues/34498).
Fixing regression introduced in os-autoinst#4803, pressed No in one of the warnings, so got back to the expert partitioner. This only affected s390x and x86 as we don't have special warnings there. See [poo#34498](https://progress.opensuse.org/issues/34498).
So, we now can check warning if partition is too small to handle
snapshots.
On power test is currently failing due to too big prep boot partition.
See poo#34498.
Needles.
Verification runs: