Updated nis client/server test #4940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloviska
force-pushed
the
nis_client_server2
branch
from
2463e3d
to
073cf72
Compare
rwx788
reviewed
Apr 25, 2018
| configure_default_gateway; | ||
| configure_static_ip('10.0.2.3/24'); | ||
| configure_static_dns(get_host_resolv_conf()); | ||
| if ($self->firewall eq 'firewalld') { |
There was a problem hiding this comment.
Let's add check if service is already defined, like we have in yast2_nis.pm:
if ($self->firewall eq 'firewalld' && script_run 'firewall-offline-cmd --get-services | grep ypbind') {and extract common part, as we do same trick, but by manually adding service with firewall-cmd
There was a problem hiding this comment.
ypbind is being installed after start of "yast2 nis" on line 40, actually that was the initial reason why was the job failing in openQA. Therefore I have introduced a needle to check if there is any package to be installed by yast2 by itself. I guess, that the additional condition will be always true at this point.
|
needles merged I'm not sure I understood your discussion point with @rwx788 but I will merge to have it fixed :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bsc#1089851 -> reporting missing firewalld service files
bsc#1090886 -> yast2 nis client does not mount configured nfs share by itself ( on sle12sp4 works without any issues )
sle-15-Installer-DVD-x86_64-Build581.4-nis_server@64bit
sle-15-Installer-DVD-x86_64-Build581.4-nis_client@64bit
sle-12-SP4-Server-DVD-x86_64-Build0236-nis_server@64bit
sle-12-SP4-Server-DVD-x86_64-Build0236-nis_client@64bit