Media upgrade does not need test deregister #4947
Conversation
| @@ -1110,7 +1110,7 @@ sub load_consoletests { | |||
| } | |||
| } | |||
| loadtest 'console/install_all_from_repository' if get_var('INSTALL_ALL_REPO'); | |||
| if (check_var_array('SCC_ADDONS', 'tcm') && get_var('PATTERNS') && sle_version_at_least('12-SP3')) { | |||
| if (check_var_array('SCC_ADDONS', 'tcm') && get_var('PATTERNS') && is_sle('<15') && !get_var("MEDIA_UPGRADE")) { | |||
There was a problem hiding this comment.
with this PR you also exclude deregister from SLE 15 and add it for all other SLE versions lower SLE 15 . Not say that it is wrong per ce but can you explain your motivation ?
There was a problem hiding this comment.
@dehai I think you have read the sle_version_at_least('12-SP3') the wrong way around. Should be is_sle('12-SP3+'), isn't it?
There was a problem hiding this comment.
@okurz @asmorodskyi because SLE15 does not have tool chain module, it has integrated into development tools module.
There was a problem hiding this comment.
@dehai and what about SLE 12 SP1 and SLE 12 SP2 ? are you ok to deregister tcm there ?
There was a problem hiding this comment.
@dehai, I don't think it is reasonable solution here. We don't have tcm in SLE15, but we do have deregister function in SLE15. In this case, we would never run SUSEConnect -d to dergister modules in SLE15 again.
There was a problem hiding this comment.
Please put something into the code. The code should be self a explanatory, if not at least describe the reason in a comment
There was a problem hiding this comment.
@okurz added reason on comment.
There was a problem hiding this comment.
Sorry, I don't see any updated source code which would include the comment.
There was a problem hiding this comment.
@okurz I have rebased my PR, and updated reasons on commit. I don't add this long explanatory into code because this is main_common module, if added, it will be very ugly.
There was a problem hiding this comment.
@dehai I think you do better add the comment to lib/main_common.pm
|
@okurz As it has blocked some migration jobs, could you merge it if you don't have any concerns. Thanks!! |
SLE15 does not have tcm anymore, it has integrated into development tools module. But in this test module it uses tcm as certain module to test this feature. It has not suitable for SLE15 testing and we do not need to test this module in migration job group.
SLE15 does not have tcm anymore,it has integrated into development tools module.But, in this test module, it uses tcm as certain module to test this feature. It has not suitable for SLE15 testing and we do not need to test this module in migration job group.