Fix rc-local test in userspace_systemd #5135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 25, 2018 14:07
The commit fixes 'check-rc-local' test by adding dummy '/etc/init.d/boot.local file, as it is required for rc-local service to be started. According to the systemd maintainers, the file is not expected to be added by default anymore. Related tickets: [poo#32548](https://progress.opensuse.org/issues/32548), [bsc#1082976](https://bugzilla.suse.com/show_bug.cgi?id=1082976)
This commit is just a result of executed tools/tidy script, that applies all the required code style rules.
|
There seems to be a misunderstanding of what execute_test_run.pm is doing. It is a wrapper for many test suites which come from external repos. The fix for a single upstream test suite must not be done in the test runner but in the test suite itself, e.g. provide a submit request for the test package in OBS/IBS or the corresponding github project if there is any |
|
Closing the PR. Please, see further investigations in https://progress.opensuse.org/issues/32548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit fixes 'check-rc-local' test
by adding dummy '/etc/init.d/boot.local
file, as it is required for rc-local
service to be started. According to the
systemd maintainers, the file is not
expected to be added by default anymore.
Related tickets:
poo#32548,
bsc#1082976
Verification run: http://10.160.65.138/tests/19#step/1_systemd/34