Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s390x-kvm: Drop static ips due to dhcp setup #5150

Merged
merged 1 commit into from
Jun 11, 2018

Conversation

Soulofdestiny
Copy link
Contributor

@Soulofdestiny Soulofdestiny commented May 30, 2018

@Soulofdestiny Soulofdestiny added the WIP Work in progress label May 30, 2018
@Soulofdestiny Soulofdestiny changed the title s390x: Drop static ips due to dhcp setup [WIP] s390x: Drop static ips due to dhcp setup May 30, 2018
Copy link
Member

@rwx788 rwx788 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks promising!

@okurz
Copy link
Member

okurz commented Jun 6, 2018

We now have a dhcp setup for the s390 KVM guests, so get rid about static ips
Additionally improve check for open ssh port
@Soulofdestiny Soulofdestiny changed the title [WIP] s390x: Drop static ips due to dhcp setup s390x: Drop static ips due to dhcp setup Jun 11, 2018
@Soulofdestiny Soulofdestiny removed the WIP Work in progress label Jun 11, 2018
@Soulofdestiny Soulofdestiny changed the title s390x: Drop static ips due to dhcp setup s390x-kvm: Drop static ips due to dhcp setup Jun 11, 2018
@Soulofdestiny
Copy link
Contributor Author

I'm ready to go for this.
once merged, I will take care about modifying existing images as well as adapt the existing testcases accordingly.
Please dont forget to merge this!

@okurz okurz merged commit 47f4e91 into os-autoinst:master Jun 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants