Delete obsolete workarounds for unexpected serial output #5379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the getty processes on the serial device are disabled after 28070eb we should not need workarounds anymore. Related progress issue: https://progress.opensuse.org/issues/30613
asdil12
force-pushed
the
fix/poo30613_workaround
branch
from
03329f4
to
ce296d6
Compare
|
Fixed your commit. |
|
@okurz I don't have any hyper-v worker to test this. How should we proceed here? |
|
We can either trust the changes and try it out in production or you get access to a hyperv worker. I think the latter is a better approach for the future. Talk to @OleksandrOrlov as he is the QSF hyperv openQA expert |
|
We need to hold this back for now - see https://progress.opensuse.org/issues/30613 |
|
true, forgot to mark the PR as such, thx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the getty processes on the serial device are disabled after
28070eb we should not need workarounds anymore.
Related progress issue: https://progress.opensuse.org/issues/30613