Update evolution server preparation for SLE15 #5405
Conversation
| assert_script_run "sed -i -e 's/auth_mechanisms = plain/auth_mechanisms = plain login/g' /etc/dovecot/conf.d/10-auth.conf"; | ||
| assert_script_run "sed -i -e '96,98 s/#//g' /etc/dovecot/conf.d/10-master.conf"; | ||
| my $uncomment_lines = is_sle("15+") ? "107,109" : "96,98"; |
There was a problem hiding this comment.
looks tricky. no easy way to understand from test code what you actually uncommenting. also, any add/remove lines from 10-master.conf will require an update of this line. Any chance change this to query for some certain text ?
There was a problem hiding this comment.
I see that you just keep the same behavior as it was before. But still, maybe you can come up with some regex which would do the same without hardcode lines needed to uncomment?
If you insist to keep it like this, could you at least add a comment describing what you actually trying to uncomment?
| select_console 'x11'; | ||
| } | ||
|
|
||
| sub test_flags() { | ||
| return {milestone => 1}; # add milestone flag to save setup in lastgood VM snapshot | ||
| return {milestone => 1}; # add milestone flag to save setup in lastgood VM snapshot |
There was a problem hiding this comment.
I remember there was a big PR which was removing such comments. It is generic openQA param which described at https://github.com/os-autoinst/openQA/blob/master/docs/WritingTests.asciidoc. No point to keep this explanation in every place it is used. Instead of proper alignment could you please just delete it ?
There was a problem hiding this comment.
I meant comment of course :) not test flag , it is up to you where to use a flag :)
Fix poo#37674: Adapt dovecot configuration to SLE15, add assert/click to send/receive button to increase test stability.
Fix poo#37674: Adapt dovecot configuration to SLE15, add assert/click
to send/receive button to increase test stability.
Tests which were fixed are:
evolution_prepare_servers
evolution_mail_imap
evolution_mail_pop
evolution_timezone_setup
evolution_meeting_imap
evolution_meeting_pop
SLE12 http://10.100.12.105/tests/2505
SLE15 http://10.100.12.105/tests/2491