Exclude never worked user_defined_snapshots on xen #5428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnowaksuse
approved these changes
Jul 19, 2018
|
typo "snapsots" in commit message title |
okurz
reviewed
Jul 19, 2018
lib/main_common.pm
Outdated
| @@ -1370,7 +1370,7 @@ sub load_extra_tests_desktop { | |||
| # start extra x11 tests from here | |||
| loadtest 'x11/vnc_two_passwords'; | |||
| # TODO: check why this is not called on opensuse | |||
| loadtest 'x11/user_defined_snapshot'; | |||
| loadtest 'x11/user_defined_snapshot' unless (check_var('VIRSH_VMM_FAMILY', 'xen') && check_var('VIRSH_VMM_TYPE', 'linux')); | |||
There was a problem hiding this comment.
Please add a comment here why the module is excluded. It should be obvious from the code why we treat these machines in a special way
OleksandrOrlov
force-pushed
the
35574_user_defined_snapshot
branch
from
b2e15f5
to
77daa39
Compare
OleksandrOrlov
changed the title
The commit excludes the module from extra_tests_on_gnome job for xen pv, as it was never passed due to the fail of interacting with grub. [poo#35574](https://progress.opensuse.org/issues/35574)
OleksandrOrlov
force-pushed
the
35574_user_defined_snapshot
branch
from
77daa39
to
e04eea1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit excludes the module from extra_tests_on_gnome job for xen pv, as it was never passed due to the fail of interacting with grub.
For reviewers: After discussion during planning game, it was decided to exclude the module and postpone the further investigations related to the issue (Please see 'Suggestions' section of the related ticket).
Related ticket: poo#35574