Handle new mediacheck-select-device needle #5471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needle merged |
now that linuxrc may reports a new screen with correction https://bugzilla.suse.com/show_bug.cgi?id=1036004 WARNING: keep the insane 3600s timeout as do not know the condition that added it ! Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
|
LGTM, and verified links? |
rwx788
reviewed
Jul 30, 2018
| send_key "ret"; | ||
| if (match_has_tag('mediacheck-checksum-wrong')) { | ||
| die "Checksum reported as wrong"; | ||
| while ($iterations++ < 3) { |
There was a problem hiding this comment.
Is it kind of workaround? What is the reason to have a loop here?
There was a problem hiding this comment.
Thank you @rwx788; this patch is not a workaround, the loop is present to continue to support the "old" linuxrc version for release other than TW that do not have yet support of this new screen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that linuxrc may reports a new screen with correction
https://bugzilla.suse.com/show_bug.cgi?id=1036004
need new needle as provided by os-autoinst/os-autoinst-needles-opensuse#402
validated locally in my openQA instance with ppc64/ppc64le with TW Build 602.2