Improvements to start_wayland_plasma5 #5496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The workaround shouldn't be necessary anymore, so remove it for reliability and speed benefits.
Also use the new set_tty function now.
rwx788
approved these changes
Aug 1, 2018
|
A new snapshot got released on o3 which broke one of the (still running) verification runs - I cloned a newer one (144) and it passes. |
|
Good job! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workaround is no longer necessary and removing it seems to fix some performance issues/hangs in later tests.
Using XDG_VTNR and the console's
set_ttymethod should fix the failure caused by the cleanup_shutdown split changes.http://10.160.67.86/tests/140 (Leap 15.0 Live)
http://10.160.67.86/tests/138 (Tumbleweed Live)
http://10.160.67.86/tests/144 (Tumbleweed Live + cleanup_shutdown split)