Introduce LVM thin volume test #5520

mloviska · 2018-08-06T07:43:09Z

Related ticket: [sle][functional][yast][y][mandatory][medium] LVM Thin Provisioning on openSUSE
Needles: NEW:Select first drive in add VG menu #408
Verification runs:
*opensuse-Tumbleweed-DVD-x86_64-BuildBuild20180731-lvm_thin_volumes@64bit
*opensuse-Tumbleweed-DVD-x86_64-BuildBuild20180731-lvm_thin_volumes@64bit - post fail hook

rwx788 · 2018-08-06T08:03:38Z

lib/partition_setup.pm

@@ -165,6 +165,9 @@ sub addlv {
    send_key 'ret';    # create logical volume
    assert_screen 'partition-lv-type';
    type_string $args{name};
+
+    send_key($args{thinpool} ? 'alt-t' : $args{thinvolume} ? 'alt-i' : 'alt-o');


So now in case it's not thin pool or thin volume we additionally press alt-o. Can it have any impact on existing tests?

It should not http://dhcp128.suse.cz/tests/5120#step/partitioning_lvm_thin_provisioning/47

rwx788 · 2018-08-06T08:06:59Z

tests/installation/lvm_thin_check.pm

+    assert_script_run 'lvs -a';
+    assert_script_run 'pvs -a';
+    # thin volume does not exceed thin pool size in our tests
+    #my $thin_volume_size = script_output q[lvs | grep Vwi | awk '{print $(NF-1)}' | cut -d'.' -f 1];


Let's not leave any commented code.

rwx788 · 2018-08-06T08:07:31Z

tests/installation/lvm_thin_check.pm

+
+    foreach (@volumes) {
+        chomp;
+        assert_script_run "lvdisplay $_";


What's about adding some more validation, except return code of the command?

rwx788 · 2018-08-06T08:09:38Z

tests/installation/partitioning_lvm_thin_provisioning.pm

+use partition_setup qw(create_new_partition_table addpart addlv);
+use version_utils 'is_storage_ng';
+
+sub addvg {


What's about moving it to lib/partition_setup.pm so if someone needs same method she/he can find it easier?

rwx788 · 2018-08-06T08:11:26Z

tests/installation/partitioning_lvm_thin_provisioning.pm

+    type_string $args{name};
+    wait_screen_change { send_key 'tab' } for (0 .. 1);
+    wait_screen_change { send_key 'spc' };
+    assert_screen 'partition-select-first-from-top';


JFYI, as long as we don't run it yet in textmode, we could use assert_and_click, which is a bit more scalable in case of UI changes.

rwx788 · 2018-08-06T08:14:52Z

lib/main_common.pm

@@ -398,6 +398,7 @@ sub load_reboot_tests {
            }
        }
        loadtest "installation/first_boot";
+        loadtest "installation/lvm_thin_check" if get_var('LVM_THIN_LV');


IMHO, we should move this to console tests, as running consoletest_setup is definitely not a bad idea. I also don't find it wrong if we run only this test module after we finish installation, but it doesn't belong here. WDYT?

No probs at all. This is just a mere suggestion where it can be placed, besides it saved a bit waiting time for me.

hm...but on the other thought, we would need to run console tests after installation, which does not happen always.

Yep, so basically I would say that it would be enough just to run this test module (with consoletest_setup in front). Or put it in console tests and execute same set of tests we run on cryptlvm (e.g. https://openqa.suse.de/tests/1896209).

rwx788 · 2018-08-06T08:18:14Z

Needles are merged.

rwx788 · 2018-08-06T10:28:15Z

tests/installation/partitioning_lvm_thin_provisioning.pm

+sub run {
+    create_new_partition_table;
+    # create boot and 2 lvm partitions
+    addpart(role => 'raw', fsid => 'bios-boot', size => 2);


Could you please update ticket for SLE to adjust this line for other architectures? We need prep boot on ppc64, boot/zipl for s390x and efi for UEFI (aarch64).

rwx788

LGTM

mloviska · 2018-08-06T11:18:49Z

tests/console/lvm_thin_check.pm

+
+    foreach (@volumes) {
+        chomp;
+        assert_script_run "lvdisplay $_";


@rwx788, please wait with the merge. I am still working on extra check over here.

Right, I've added WIP label just for the case. Thanks for the reminder =)

More changes to come

mloviska · 2018-08-07T13:39:26Z

I do not have rights to remove WIP label...

rwx788

Some minor comments, but could you also squash or change commit messages?

rwx788 · 2018-08-07T13:55:34Z

tests/console/lvm_thin_check.pm

+        chomp;
+        my $lvdisp_out = script_output "lvdisplay $volume";
+        foreach (keys %{$lv_stats}) {
+            die "Value of $_" unless ($lvdisp_out =~ /(?<tested_string>$lv_stats->{$_})/);


Could you please put a bit more details in the die message, so reason is more obvious.

rwx788 · 2018-08-07T13:56:47Z

tests/console/lvm_thin_check.pm

+    }
+}
+
+sub post_fail_hook {


I guess standard set of logs could be helpful here too, so what's about calling SUPER postfail hook too?

mloviska · 2018-08-08T08:26:16Z

We are missing needles:
os-autoinst/os-autoinst-needles-opensuse#408

okurz · 2018-08-08T08:27:49Z

done

rwx788 · 2018-08-08T08:52:28Z

Ah, somehow got a feeling that already merged them. Thanks! ;)

mloviska · 2018-08-08T09:10:18Z

@rwx788, That is my fault! Sorry! I should let you know that with the assert_and_click 'partition-select-first-from-top'; change I had to replace one needle.

rwx788 · 2018-08-08T09:21:15Z

@mloviska no worries, you did a great job by reminding to merge ;)

mloviska force-pushed the partitioning_lvm_thin branch from 83a41ea to 3f67bb8 Compare August 6, 2018 07:44

mloviska mentioned this pull request Aug 6, 2018

Add needles for lvm thin volume os-autoinst/os-autoinst-needles-opensuse#406

Merged

rwx788 reviewed Aug 6, 2018

View reviewed changes

mloviska force-pushed the partitioning_lvm_thin branch from 2b4f3a3 to ec1fac5 Compare August 6, 2018 09:20

rwx788 reviewed Aug 6, 2018

View reviewed changes

rwx788 previously approved these changes Aug 6, 2018

View reviewed changes

mloviska commented Aug 6, 2018

View reviewed changes

rwx788 added the WIP Work in progress label Aug 6, 2018

mloviska mentioned this pull request Aug 7, 2018

Select first drive in add VG menu os-autoinst/os-autoinst-needles-opensuse#408

Merged

rwx788 removed the WIP Work in progress label Aug 7, 2018

rwx788 reviewed Aug 7, 2018

View reviewed changes

Introduce LVM thin volume test

e6a4dec

mloviska force-pushed the partitioning_lvm_thin branch from 8b34729 to e6a4dec Compare August 7, 2018 14:05

rwx788 merged commit 5865a13 into os-autoinst:master Aug 8, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduce LVM thin volume test #5520

Introduce LVM thin volume test #5520

mloviska commented Aug 6, 2018 •

edited

rwx788 Aug 6, 2018

mloviska Aug 6, 2018

rwx788 Aug 6, 2018

rwx788 Aug 6, 2018

rwx788 Aug 6, 2018

rwx788 Aug 6, 2018

rwx788 Aug 6, 2018

mloviska Aug 6, 2018

mloviska Aug 6, 2018

rwx788 Aug 6, 2018

rwx788 commented Aug 6, 2018

rwx788 Aug 6, 2018

mloviska Aug 7, 2018

rwx788 left a comment

mloviska Aug 6, 2018

rwx788 Aug 6, 2018

mloviska commented Aug 7, 2018

rwx788 left a comment

rwx788 Aug 7, 2018

rwx788 Aug 7, 2018

mloviska Aug 7, 2018

mloviska commented Aug 8, 2018

okurz commented Aug 8, 2018

rwx788 commented Aug 8, 2018

mloviska commented Aug 8, 2018

rwx788 commented Aug 8, 2018

Introduce LVM thin volume test #5520

Introduce LVM thin volume test #5520

Conversation

mloviska commented Aug 6, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwx788 commented Aug 6, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rwx788 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mloviska commented Aug 7, 2018

rwx788 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mloviska commented Aug 8, 2018

okurz commented Aug 8, 2018

rwx788 commented Aug 8, 2018

mloviska commented Aug 8, 2018

rwx788 commented Aug 8, 2018

mloviska commented Aug 6, 2018 •

edited