Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update window_system to make ensure permission #5555

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

yuanren10
Copy link
Contributor

@yuanren10 yuanren10 commented Aug 9, 2018

Add ensure_serialdev_permissions into window_system to
make user Berhard and /dev/ttyS0 belongs to the same
group.

Reference:
Before update test run
After update test run

Add ensure_serialdev_permissions into window_system to
make the user Berhard and /dev/ttyS0 belongs to the same
group.
@yuanren10
Copy link
Contributor Author

yuanren10 commented Aug 9, 2018

@okurz @rwx788 This is a workaround way to solve write permission to /dev/ttyS0, we have discussed in #5492 . modified code may can use "x11/x11_setup" to replace, but I try to don't modify "main_common.pm".
We have to deal with permission issue on Tumbleweed.
Consider all situation we had discussed, I choose to update in this way, although I still recommend to move "consoletest_setup" into create_hdd_* :)
But this PR wouldn't cause any crash at least.

@yuanren10
Copy link
Contributor Author

As for #5492 I think it can be merged. Because the "hostname" case is really overloaded.
As for #5539 and #5494 is still waiting have the right group permission as above said. I will update pull a new commit to update these PR once this PR merged. So, in case of mess up, let's just start with this one and #5492 please.

@rwx788 rwx788 merged commit f5032db into os-autoinst:master Aug 9, 2018
@yuanren10
Copy link
Contributor Author

@rwx788 Please revert and close this PR. You did a great job in #5564 , "console/system_prepare" had done what I want to. So, we do not need to check permission again in "window_system".
Verfication Run:
create_hdd_gnome
window_system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants