Remove workaround for shutdown on KDE plasma5 #5559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit removes workaround for the sutdown flow that breaks the test as it checks twice for the same needle sddm_shutdown_option_btn. The problem was that after first match the test immediately checks for the same needle and founds it as system a little bit slow, then it tries to press the shutdown button again, but the appropriate popup has already gone. [poo#36040](https://progress.opensuse.org/issues/36040)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit removes workaround for the sutdown flow that breaks the test
as it checks twice for the same needle sddm_shutdown_option_btn.
The problem was that after first match the test immediately checks for
the same needle and founds it as system a little bit slow, then it tries
to press the shutdown button again, but the appropriate popup has
already gone.
For reviewers: The workaround was added in two places. The one for reboot was removed by #5409. This one removes the workaround for shutdown case.