Allow removing single patterns from default selection #5588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Aug 15, 2018
| @@ -185,11 +186,19 @@ sub run { | |||
| die "looping for too long" unless ($counter--); | |||
| my $needs_to_be_selected; | |||
| my $ret = check_screen('on-pattern', 1); | |||
| my $current_pattern = 'UNKNOWN_PATTERN'; | |||
|
|
|||
| if ($ret) { # unneedled pattern | |||
| for my $wp (keys %wanted_patterns) { | |||
There was a problem hiding this comment.
I guess we need to rename wanted_patterns to something else, as now we have unwanted patterns there as well. But I like the idea!
asmorodskyi
reviewed
Aug 15, 2018
|
|
||
| if ($ret) { # unneedled pattern | ||
| for my $wp (keys %wanted_patterns) { | ||
| for my $wp (keys %patterns) { |
There was a problem hiding this comment.
since you renamed "wanted_patterns" to "patterns" which makes perfect sense to me. Maybe you also will change "wp" to pattern ?
asmorodskyi
reviewed
Aug 15, 2018
| } | ||
|
|
||
| my $counter = 80; | ||
| while (1) { | ||
| die "looping for too long" unless ($counter--); | ||
| my $needs_to_be_selected; | ||
| my $ret = check_screen('on-pattern', 1); | ||
| my $current_pattern = 'UNKNOWN_PATTERN'; |
There was a problem hiding this comment.
not sure that I understand purpose of this variable. Looks like you use it to detect if PATTERNS variable has at least one pattern to select and it is not default, right ?
eg. PATTERNS=default,-gnome,web
asmorodskyi
reviewed
Aug 16, 2018
| } | ||
|
|
||
| my $counter = 80; | ||
| while (1) { | ||
| die "looping for too long" unless ($counter--); | ||
| my $needs_to_be_selected; | ||
| my $ret = check_screen('on-pattern', 1); | ||
| # this variable will only be updated when the pattern list entry is under the cursor | ||
| # and the pattern is in the PATTERNS variable and there is a needle for that entry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eg.
PATTERNS=default,-gnome,webNeeded for https://progress.opensuse.org/issues/33985
Verification: http://artemis.suse.de/tests/430#step/select_patterns_and_packages/75