Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt yast2_proxy to new startup widget #5596

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Adapt yast2_proxy to new startup widget #5596

merged 1 commit into from
Aug 20, 2018

Conversation

mloviska
Copy link
Contributor

@mloviska mloviska commented Aug 16, 2018 •
edited
Loading

@mloviska mloviska mentioned this pull request Aug 16, 2018
Merged
@jknphy
Copy link
Contributor

jknphy commented Aug 17, 2018 •
edited
Loading

LGTM, except for some needles missed in last push, but I guess we can recreate them.

@jknphy
Copy link
Contributor

jknphy commented Aug 17, 2018 •
edited
Loading

As far as I could test we need to recreate missing needles only for openSUSE.

@jknphy
Copy link
Contributor

jknphy commented Aug 20, 2018

Finally I found them in another PR not linked: os-autoinst/os-autoinst-needles-opensuse#413

rwx788
rwx788 reviewed Aug 20, 2018
View reviewed changes
tests/console/yast2_proxy.pm Outdated
send_key_until_needlematch 'yast2_ncurses_service_start_widget_start_on_boot', 'up';
send_key 'ret';
assert_screen 'yast2_ncurses_service_start_widget_check_start_on_boot';
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove this line here

@rwx788 rwx788 force-pushed the yast2_proxy_update_startup_widget branch from 449cbed to 0fe86e7 Compare August 20, 2018 09:34
@rwx788 rwx788 merged commit e3036ed into os-autoinst:master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwx788 rwx788 rwx788 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@mloviska @jknphy @rwx788