Add post_fail_hook for shutdown issue #5624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please tidy |
|
@Soulofdestiny I did this already. I had problem with my older tidy version. |
|
@OleksandrOrlov could you please check - you've implemented a lot around shutdown recently |
tests/x11/user_defined_snapshot.pm
Outdated
| @@ -55,6 +55,8 @@ sub run { | |||
| power_action('reboot', keepconsole => 1, textmode => 1); | |||
|
|
|||
| $self->handle_uefi_boot_disk_workaround() if get_var('MACHINE') =~ qr'aarch64'; | |||
| # post_fail_hook from opensusebasetest triggers if shutdown takes too long time | |||
| $self->{in_wait_boot} = 1; | |||
There was a problem hiding this comment.
I guess, the $self->{in_wait_boot} = 1; line should be before power_action('reboot'...), as assert_shutdown function is located inside of the power_action.
If it will fail on assert_shutdown, then code will never reach the $self->{in_wait_boot} = 1; line and in_wait_boot in post_fail_hook will equal to '0'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://e13.suse.de/tests/7555#step/user_defined_snapshot/22