Adapt new ServiceWidget - y2proxy & y2http #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
AFIK dev progresses in parallel regarding sle 15 and leap15, the only doubt that I have is if |
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
rwx788
reviewed
Aug 23, 2018
tests/console/yast2_http.pm
Outdated
| @@ -102,7 +102,7 @@ sub run { | |||
| assert_screen 'http_vitual_host_page'; # check wizard page (4/5) | |||
| send_key 'alt-n'; # go to http server wizard (5/5) --summary | |||
| # make sure that apache2 server got started when booting | |||
| if ((is_sle '<15') || (is_leap)) { | |||
| if (is_sle('<15') || is_leap('<15.0')) { | |||
There was a problem hiding this comment.
It's alright to keep original version as we execute this test against latest products only. But if we want to be strict it should be <15.1 then, as 15.0 will get these changes as updates only.
jknphy
force-pushed
the
new_widget_leap
branch
3 times, most recently
from
d11a1a2
to
759c6b8
Compare
jknphy
changed the title
rwx788
reviewed
Aug 24, 2018
tests/console/yast2_http.pm
Outdated
| send_key_until_needlematch 'yast2_ncurses_service_start_widget_start_on_boot', 'up'; | ||
| send_key 'ret'; | ||
| assert_screen 'yast2_ncurses_service_start_widget_check_start_on_boot'; | ||
| $self->SUPER::assert_service_widget(after_writing_conf => 'alt-w', after_reboot => 'alt-e'); |
There was a problem hiding this comment.
I don't think we need SUPER here, as you don't override method in inherited class.
tests/console/yast2_proxy.pm
Outdated
| send_key_until_needlematch 'yast2_ncurses_service_start_widget_start_on_boot', 'up'; | ||
| send_key 'ret'; | ||
| assert_screen 'yast2_ncurses_service_start_widget_check_start_on_boot'; | ||
| $self->SUPER::assert_service_widget; |
jknphy
force-pushed
the
new_widget_leap
branch
from
759c6b8
to
8efb517
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt new ServiceWidget - yast2_proxy and yast2_http taking into account that Leap 15.1 recently received it as we can see here. I also would like to provide some refactor.