Add integration to new service configuration widget

[jknphy]

Add integration to new service configuration widget. It includes: yast2_proxy, yast2_samba, yast2_dns_server, yast2_http and yast2_ftp using a mapped version of the user control due to it was necessary to control different behaviors (start, stop, disabled, ...) besides reusing code.

• Related ticket: https://progress.opensuse.org/issues/39725
• Needles:
  • openSUSE
  • SLE
• Verification run:
  • Tumbleweed-yast2_ncurses
  • sle-15-SP1-yast2_ncurses

[rwx788]

I guess it's a bit of overkill to use an array here, with 2 variables it would be more clear and readable. Here we rely on the order, don't check if array element exists at all. I also see that we always pass the same pairs, meaning that we can even map keys in the method itself depending on the action.

[jknphy]

Are you referring to something like this, right?
my ($after_writing_conf_ref, $after_reboot_ref) = $args;
Good point I can shorten the calls using order, makes sense. For a couple of cases that I am using default values, I can make it mandatory and it is more simple.

The pairs are different, as far as I could find, for example for after_writing_conf: alt-t, alt-f and alt-e. I like the idea to map keys inside the method and not repeat keys but they don't depend on the action, they depends on the caller (and for a while until the shortcut changes again).

The general idea that I tried to implement is that the caller to the subroutine can pass parameters according to what is displayed in the screen, so no need to take care about internals of the subroutine. If he/she sees any shortcut for any field, then use it.

Let me see if with you with your advice I can present it in a different way.

[jknphy]

Another smart way to avoid to pass the shortcut and handle them inside would be to match against an array of needles, each one pointing to the same field title with different shortcut, i.e.:
yast2_ncurses_service_after_writing_conf_alt_t.json(png) yast2_ncurses_service_after_writing_conf_alt_f.json(png) yast2_ncurses_service_after_writing_conf_alt_e.json(png)
Therefore we could pass the action, we decide the shortcut according to matching, accessing the field and the perform the action. The only con that I see that I don't know how often wrong needles are created, if the frequency is too much to trust on that, it's better to have the logic in the code hardcoded as it is now, WDYT?

[jknphy]

Discussed possible approaches with @rwx788.
VR with new changes: Tumbleweed-yast2_ncurses

[asmorodskyi]

before creating this variable had sense because in case nothing passed into a function it will assign default value. but you remove default values so you can :

sub change_service_configuration {
 my ($self, %args) = @_;
 change_service_configuration_step('after_writing_conf', $args{after_writing}) if $args{after_writing};
 change_service_configuration_step('after_reboot',       $args{after_writing})  if $args{after_reboot};
}

but you can say that it is matter of taste and I will not argue :)

[jknphy]

There were many combinations and the default values didn't really help. For clarity is all passed to the subroutine and if not, means that we want to select specific field to change, as you said, a matter of taste :)

Changes in the code

[rwx788]

I guess this is unwanted change

[rwx788]

You could use $self->setup_samba here which is more common, but still is a matter of taste.

[rwx788]

Is is the case that we have different conditions for different YaST modules? I see 3 variations, wonder if it's the case.

[jknphy]

wrong paste, good catch! We have two cases, is_sle('<15') || is_leap('<15.1') and another one that also include tw, as in samba is not yet for that product.