Add service widget for iscsi #5712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
jknphy
force-pushed
the
add_service_widget_iscsi
branch
from
a63162d
to
996bd0e
Compare
jknphy
changed the title
jknphy
force-pushed
the
add_service_widget_iscsi
branch
from
996bd0e
to
2af271b
Compare
rwx788
reviewed
Sep 10, 2018
tests/iscsi/iscsi_client.pm
Outdated
| wait_still_screen(2, 10); | ||
| unless (is_sle('<15') || is_leap('<15.1')) { | ||
| change_service_configuration( | ||
| after_writing => {start => 'alt-f'}, |
There was a problem hiding this comment.
Hmm, service status is partly-active, I guess it's because it's activated by socket, so I would say it's fine to keep current state for client, we also don't really have to change on reboot setting, so to be honest, I would skip these steps here.
jknphy
force-pushed
the
add_service_widget_iscsi
branch
4 times, most recently
from
39296d7
to
684d19f
Compare
jknphy
force-pushed
the
add_service_widget_iscsi
branch
from
684d19f
to
95cda4a
Compare
|
Kept current status for client as suggested. |
|
Let's try it out, changes LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add service widget for iscsi. Widget was successfully integrated in a base file for text mode. Logic has been moved to a util file so it can be used from graphical and text mode. Timeout increased for detecting targets in iscsi_client.