Improve validation AWS packages #5790
Conversation
jknphy
changed the title
| packages => \@aws_pattern_packages, | ||
| packages => ['aws-cli', 'cloud-init', 'cloud-regionsrv-client', 'cloud-regionsrv-client-plugin-ec2', | ||
| 'docker-img-store-setup', 'growpart', 'patterns-public-cloud-' . $aws_specific{sle_version} . 'Amazon-Web-Services', | ||
| $aws_specific{py_version} . '-ec2deprecateimg', $aws_specific{py_version} . '-ec2metadata', |
There was a problem hiding this comment.
I was also concerned how strict we should be with packages names, so that it's not pain to maintain. So, let's try it put and see if it worth it, or we can be less strict with search.
There was a problem hiding this comment.
I agree, it is a refactor to avoid so many lines of code and conditions, but if it is painful to maintain we can do it in different way in the future.
| # Different pattern and packages names on SLE 15 and SLE 12 | ||
| my %aws_specific = is_sle('15+') ? (name => 'Amazon_Web_Services', sle_version => '15-', py_version => 'python3') : | ||
| (name => 'Amazon-Web-Services', py_version => 'python'); | ||
| $software{%aws_specific{name}} = { |
There was a problem hiding this comment.
this is not valid perl - I wonder how you validated this, but your validation run is unreachable
There was a problem hiding this comment.
I assume you came to this PR due to broken tests? Feel free to revert the change in a revert PR and ping the author to bring back the changes properly
There was a problem hiding this comment.
Thanks for the feedback and the revert and sorry for the inconvenience.
I can see in the logs of the validations both errors, but they didn't produce a failed job on my local machine neither detected by Travis. Is there something in my configuration that I should tweak to avoid this in the future?
New PR: #5795
There was a problem hiding this comment.
It's very possible that the old sle12 perl is different - why travis didn't catch it, I don't know
Improve validation aws packages after bug Differences in the content of pattern Amazon Web Service between SLE12SP4 and SLE15.1 was confirmed: