Add more warnings checks for storage-ng #5793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloviska
force-pushed
the
partition_warnings
branch
from
e53c7fc
to
31df02a
Compare
SergioAtSUSE
requested changes
Sep 18, 2018
| # Warnings: | ||
| # 1) no / | ||
| # 2) no boot | ||
| # 3) boot with minimul size and correct ID |
There was a problem hiding this comment.
little typo here: s/minimul/minimal/
| process_warning(warning => 'no-swap'); | ||
| return; | ||
| process_warning(warning => 'no-swap', key => 'alt-n'); | ||
| #return; |
There was a problem hiding this comment.
Did you forget to uncomment? or should it be removed?
mloviska
force-pushed
the
partition_warnings
branch
from
31df02a
to
4df0e5e
Compare
|
@SergioAtSUSE, thanks for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sle-15-SP1-Installer-DVD-x86_64-Build41.4-btrfs+warnings@64bit