Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add record_info for each test case #5807

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

mloviska
Copy link
Contributor

lib/partition_setup.pm Outdated Show resolved Hide resolved
@rwx788 rwx788 merged commit 3e7e3fe into os-autoinst:master Sep 21, 2018
process_warning(warning => 'no-space-for-kernel', key => 'alt-o');
remove_partition;

## Add wrong or small boot partition
foreach (keys %roles) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, missed that in VR, this introduces weird behavior, as we test boot/zipl and ofw on x86_64, which is non-sense. I will add this to the follow up ticket we have in the next sprint.

Copy link
Contributor Author

@mloviska mloviska Sep 25, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact, that was an intention to check if the partitioner will trigger a warning when there is wrong boot partition ID.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean that we create /boot/zipl on x86_64 and check if there is still warning about bios_boot? I guess it's a bit of overkill, considering stability and scalability of our GUI tests =(

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically, user should be warned when the boot partition does not match the arch. Storage-ng checks the size for all boot partition IDs and for some it checks either ID or mount point or file system, depending on what kind of arch we are running the installer. Also the warning message is still the same, so from the point of stability, we are expecting the same needle to appear for each boot partition ID on tested architecture.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants