Ensure that send_key doesn't run on virtio console #5814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
okurz
reviewed
Sep 24, 2018
lib/console_yasttest.pm
Outdated
| select_console 'log-console'; | ||
| save_screenshot; | ||
|
|
||
| show_tasks_in_blocked_state; |
There was a problem hiding this comment.
Does not look like a good idea and I did not see any test runs conducted by you. This way the test would fail whenever we can not log into the logconsole, exactly what we wanted to fix in the first place. AFAICS this code change is defeating the whole purpose.
There was a problem hiding this comment.
I could alternatively only run show_tasks_in_blocked_state unless testapi::is_serial_terminal().
There was a problem hiding this comment.
Test for old patch (to be replaced in a minute): http://artemis.suse.de/tests/480
|
Test for new patch: http://artemis.suse.de/tests/483 |
okurz
reviewed
Sep 24, 2018
lib/console_yasttest.pm
Outdated
| if ($defer_blocked_task_info) { | ||
| show_tasks_in_blocked_state; | ||
| } | ||
|
|
There was a problem hiding this comment.
How about – personal taste:
my $defer_blocked_task_info = testapi::is_serial_terminal() ? 1 : 0;
show_tasks_in_blocked_state unless $defer_blocked_task_info;
…
show_tasks_in_blocked_state if $defer_blocked_task_info;
SergioAtSUSE
approved these changes
Sep 25, 2018
Call show_tasks_in_blocked_state after selecting non-virtio console if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call show_tasks_in_blocked_state after selecting
non-virtio console.
https://progress.opensuse.org/issues/39497