Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] ensure_installed should assure that terminal get closed #5830

Closed
wants to merge 1 commit into from
Closed

[WIP] ensure_installed should assure that terminal get closed #5830

wants to merge 1 commit into from

Conversation

SergioAtSUSE
Copy link
Member

@SergioAtSUSE SergioAtSUSE commented Sep 26, 2018 •
edited
Loading

@SergioAtSUSE SergioAtSUSE mentioned this pull request Sep 26, 2018
Merged
@okurz
Copy link
Member

okurz commented Oct 1, 2018

Sorry to potentially annoy you but you give a bit more reasoning behind that change? Did you take a look into other test modules or just gnucash?

@SergioAtSUSE
Copy link
Member Author

@okurz, let's wait for this hitting on O3. This race condition may be not reproducible on O3 workers.

I only looked at gnucash. But I assume the problem can also hit others. Do you mean to also verify my changes on other modules?

@okurz
Copy link
Member

okurz commented Oct 11, 2018

Do you mean to also verify my changes on other modules?

Yes

@SergioAtSUSE SergioAtSUSE deleted the ensure_installed_closes_terminal branch November 27, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
notready
Projects
None yet
Milestone
No milestone
2 participants
@SergioAtSUSE @okurz