Fix partition raid for UI changes - rest of archs #5924
Conversation
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
jknphy
force-pushed
the
fix_raid_ppc
branch
3 times, most recently
from
5bbe001
to
6fdcb83
Compare
jknphy
changed the title
jknphy
changed the title
jknphy
changed the title
|
|
||
| sub add_raid_swap { | ||
| # for newer storage-ng toolbar has changed | ||
| $cmd{addraid} = 'alt-d' unless $older_product; |
There was a problem hiding this comment.
It's the same line in multiple places. Why not to move it at least to run subroutine, or even better to tests/installation/partitioning.pm where we redefine shortcuts already to have it in single place.
There was a problem hiding this comment.
I tried on top of the file, but it didn't work, Perl evaluate it before $older_product. I don't have scope of the code in partitioning.pm yet, so let's put it in run until the refactor in poo#42401.
| @@ -20,6 +20,24 @@ use version_utils qw(is_storage_ng is_sle is_leap is_tumbleweed); | |||
| # tumbleweed is not older product, but it didn't roll out yet | |||
| my $older_product = is_sle('<15') || is_leap('<15.1') || is_tumbleweed; | |||
There was a problem hiding this comment.
I have introduced is_storage_ng_newui in lib/partition_setup.pm. To be honest I would use just a single place, so when changes reach TW it would be single change instead of multiple places, which we already have. But that's just a side note.
There was a problem hiding this comment.
Same thing for partition_setup.pm. I can check how to integrate it in subsequent ticket.
There was a problem hiding this comment.
Yes, please add it there, so we reuse same peace of code.
|
Needles merged. |
Description: Remaining archs than x86_64 need specific adaptions for raid partition:
(or part of it?) but I cannot provide VR as the shared worker, according to @zluo has some problems with qemu 3.0 and needs to be downgradedShared worker for ppc is working but as usual, take to much time after many tries to get a single job matching the needles due it suffers of some graphic problem. Nevertheless I got one good.runand createsubfor different actions.Related ticket: https://progress.opensuse.org/issues/41849
Needles: needles sle
Verification run: