Fix lvm on top of raid partitioning #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
rwx788
reviewed
Oct 17, 2018
| if ($older_product) { | ||
| send_key "alt-d"; | ||
| send_key "down"; | ||
| send_key "down"; |
There was a problem hiding this comment.
Will it help to use send_key_until here?
There was a problem hiding this comment.
might be but who cares about older products? ;) At least I guess it should not be done in the same commit. Even we could merge this PR to provide the fix faster and then think about optimizing the robustness
There was a problem hiding this comment.
Yes, we have raised this point. We are maintaining 3 code flows now, which can become another mirror of main.pm issues =)
There was a problem hiding this comment.
Ah, I've missed that it's old code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjustment in drop-down menu due to new Storage-ng UI when using lvm on top or raid partitioning.