Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add valid bugref to power_action_utils #6007

Merged
merged 1 commit into from Oct 23, 2018

Conversation

DrMullings
Copy link
Contributor

Now the default value of the soft timeout is bsc#1055462
"openQA test fails in shutdown - machine fails to shutdown within
one minute"

@okurz
Copy link
Member

okurz commented Oct 21, 2018

@OleksandrOrlov ?

@OleksandrOrlov
Copy link
Contributor

I guess we shouldn't make the default value to be contained the bugref.

The soft-fail raised for that case because the test suite contains LIVECD variable. And the appropriate issue is https://bugzilla.suse.com/show_bug.cgi?id=1096241.

So, my suggestion is to leave default value as is ('No bugref specified') and to just add 'bugref' to soft_fail_data for LIVECD case:

    if (get_var('LIVECD')) {
        $soft_fail_data = {bugref=>'bsc#1096241', soft_timeout => 60, timeout => $shutdown_timeout *= 4};
    }

Actually it should already be specified. It seems like I missed this 'bugref' while implemented the subroutine.

@@ -310,7 +310,7 @@ sub assert_shutdown_with_soft_timeout {
my ($args) = @_;
$args->{timeout} //= 60;
$args->{soft_timeout} //= 0;
$args->{bugref} //= "No bugref specified";
$args->{bugref} //= "bsc#1055462";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we shouldn't make the default value to be contained the bugref.

The soft-fail raised for that case, because the test suite contains LIVECD variable. And the appropriate issue is https://bugzilla.suse.com/show_bug.cgi?id=1096241.

So, my suggestion is to leave default value as is ('No bugref specified') and to just add 'bugref' to the soft_fail_data for LIVECD case:

    if (get_var('LIVECD')) {
        $soft_fail_data = {bugref=>'bsc#1096241', soft_timeout => 60, timeout => $shutdown_timeout *= 4};
    }

Actually it should already be specified. It seems like I missed this 'bugref' while implemented the subroutine.

@OleksandrOrlov
Copy link
Contributor

I guess we shouldn't make the default value to be contained the bugref.

The soft-fail raised for that case, because the test suite contains LIVECD variable. And the appropriate issue is https://bugzilla.suse.com/show_bug.cgi?id=1096241.

So, my suggestion is to leave default value as is ('No bugref specified') and to just add 'bugref' to the soft_fail_data for LIVECD case:

    if (get_var('LIVECD')) {
        $soft_fail_data = {bugref=>'bsc#1096241', soft_timeout => 60, timeout => $shutdown_timeout *= 4};
    }

Actually it should already be specified. It seems like I missed this 'bugref' while implemented the subroutine.

@DrMullings
Copy link
Contributor Author

@OleksandrOrlov statement was that we should keep the default as is and just add a bugref for LIVECD

1 similar comment
@DrMullings
Copy link
Contributor Author

@OleksandrOrlov statement was that we should keep the default as is and just add a bugref for LIVECD

Now bsc#1096241 is referenced for LIVECD tests taking too long
to shutdown
@DrMullings
Copy link
Contributor Author

Updated it accordingly

@OleksandrOrlov OleksandrOrlov merged commit 8eec554 into os-autoinst:master Oct 23, 2018
@jlausuch
Copy link
Contributor

@DrMullings
Copy link
Contributor Author

DrMullings commented Oct 23, 2018

Weird, locally I do not get errors and also the spacing and stuff look also fine
Nope there are missing spaces around the arrow, will provide fix after the review meeting

@DrMullings
Copy link
Contributor Author

#6028
Fixes this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants