Check license accepting in extended installation #6022
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An additional check if the license is accepted or not was executed in all the installation tests. The commit moves the check to 'installer_extended' test suite. [poo#42608](https://progress.opensuse.org/issues/42608)
rwx788
reviewed
Oct 23, 2018
| $self->verify_license_translations; | ||
| send_key $cmd{next}; | ||
| # workaround for bsc#1059317, multiple times clicking accept license | ||
| my $count = 5; | ||
| while (check_screen('license-not-accepted', 3) && $count >= 1) { | ||
| record_soft_failure 'bsc#1059317'; | ||
| $self->verify_license_has_to_be_accepted; | ||
| $self->accept_license(verify_license_has_to_be_accepted => 1); |
There was a problem hiding this comment.
I guess you wanted to set 1 here unconditionally and not using hash.
| sub verify_license_has_to_be_accepted { | ||
| # license+lang | ||
| sub accept_license { | ||
| my ($self, $verify_license_has_to_be_accepted) = @_; |
There was a problem hiding this comment.
I believe this variable name is too long. What's about something like extended_check or at least skipping word license, as it's clear from the subroutine name.
Also, could you please document this method using POD or just comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An additional check if the license is accepted or not was executed in all the installation tests.
The commit moves the check to 'installer_extended' test suite.
Note: My previous PR #6000 did not contain a solution for bsc#1059317 workaround. So that the PR was reverted and this one is added.