Work bsc#1103199 and bsc#1112109 around #6027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2018 10:27
We have a bug, which interferes with usage of serial console. On qemu backend it's enough to wait for welcome message on tty, which means that service is running. On Xen HVM service gets restarted constantly, so the only possible workaround is to stop it ASAP. See [poo#42359](https://progress.opensuse.org/issues/42359).
foursixnine
reviewed
Oct 23, 2018
foursixnine
reviewed
Oct 23, 2018
|
Let's do this! |
okurz
reviewed
Oct 25, 2018
| @@ -456,6 +457,8 @@ sub wait_boot { | |||
|
|
|||
| # on s390x svirt encryption is unlocked with workaround_type_encrypted_passphrase before here | |||
| unlock_if_encrypted if !get_var('S390_ZKVM'); | |||
| # On remote backends we sync on Welcome message already where possible, mitigating bsc#1112109 | |||
| wait_serial(get_login_message()) unless is_remote_backend; | |||
There was a problem hiding this comment.
Oh, so this is why we have in so many tests this failing step. The return value is ignored. Does this wait_serial actually work in your local tests?
There was a problem hiding this comment.
Now I have actually noticed that it failed on ppc64. I will create new PR to remove this one and addressing you comment below, as reverting export changes will create many conflicts.
| @@ -57,8 +61,6 @@ sub run { | |||
| assert_script_run 'less /var/log/YaST2/y2log*|grep "Automatic DHCP configuration not started - an interface is already configured"'; | |||
| } | |||
|
|
|||
| # Stop serial-getty on serial console to avoid serial output pollution with login prompt | |||
| systemctl "stop serial-getty\@$testapi::serialdev"; | |||
| # Mask if is qemu backend as use serial in remote installations e.g. during reboot | |||
| systemctl "mask serial-getty\@$testapi::serialdev" if check_var('BACKEND', 'qemu'); | |||
There was a problem hiding this comment.
It's already done: 9c0cca4
rwx788
pushed a commit
to rwx788/os-autoinst-distri-opensuse
that referenced
this pull request
Oct 26, 2018
Regression introduced in os-autoinst#6027, which doesn't work in many scenarios. Also, addressing second comment from the initial PR. See [poo#42359](https://progress.opensuse.org/issues/42359).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a bug, which interferes with usage of serial console. On qemu
backend it's enough to wait for welcome message on tty, which means that
service is running. On Xen HVM service gets restarted constantly, so the
only possible workaround is to stop it ASAP.
See poo#42359.
Verification runs
default ppc64le
default 64bit
opensuse gnome