Adjust tests for Welcome screen depending on product #6056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 25, 2018 15:01
The commit adds two functions: one for identifying cases when installer has to show Product Selection screen before the License Agreement and the second to identify cases when License has to be shown on Welcome screen. The functions are added, because different SLE versions show the License Agreement on diferent pages. Made in scope of [poo#42608](https://progress.opensuse.org/issues/42608)
Accept License logic and explicit check that license has to be accepted are divided into two separate methods. This allows to have more flexible control of the test and make the additional check only in case of extended test suite. [poo#42608](https://progress.opensuse.org/issues/42608)
rwx788
reviewed
Oct 25, 2018
Starting with SLE 15, all products are distributed using one medium, and Product to install has to be chosen explicitly. Though, there are some exceptions (like s390x) when there is only one Product, so that License agreement is shown directly, skipping the Product selection step. Also, Product Selection screen is not shown during upgrade. The commit allows to more clearly identify if the product has license on Welcome screen, or it has Product Selection step. Also, it removes unnecessary calls of keyboard_selection module as it should only be called for some specific test suites. [poo#42608](https://progress.opensuse.org/issues/42608)
OleksandrOrlov
force-pushed
the
42608_license_acceptance
branch
from
df8da77
to
f8d95fe
Compare
|
@okurz @alice-suse @dzedro we plan to merge this PR tomorrow in the morning. It touches modules that are used in every installation, so may break something. In this case, we will simply revert, but would be great if you could take a look. |
OleksandrOrlov
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with SLE 15, all products are distributed using one medium, and Product
to install has to be chosen explicitly.
Though, there are some exceptions (like s390x) when there is only one Product,
so that License agreement is shown directly, skipping the Product selection step.
Also, Product Selection screen is not shown during upgrade.
The commit allows more clearly identify if the product has license on
Welcome screen, or it has Product Selection step. Also, it removes
unnecessary calls of keyboard_selection module as it should only be
called for some specific test suites.
SLE15:
SLE12:
UPGRADE:
OPENSUSE: