Add new YaST2 UI firewalld #6113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
force-pushed
the
add_new_yast2ui_firewalld
branch
4 times, most recently
from
9fea2c6
to
3b940d5
Compare
jknphy
force-pushed
the
add_new_yast2ui_firewalld
branch
2 times, most recently
from
be6e052
to
3a2a434
Compare
rwx788
reviewed
Nov 5, 2018
tests/yast2_gui/yast2_firewall.pm
Outdated
|
|
||
| sub configure_firewalld { | ||
| record_info('Start-Up', "Managing the firewalld service"); | ||
| stop_service; |
There was a problem hiding this comment.
What's about service status asserting and not just believing that GUI did all the work?
There was a problem hiding this comment.
good suggestion, I added a new bug for that in the first comment along with VR updated.
There was a problem hiding this comment.
to verify right after the service I have to come back to the user console because I was ask for user password in the UI, very strange..., and now a "workaround box" appears. Do you think is correct the transition? Forget about it, it is not needed. Updated.
rwx788
reviewed
Nov 5, 2018
jknphy
force-pushed
the
add_new_yast2ui_firewalld
branch
from
3a2a434
to
b68a7cd
Compare
jknphy
force-pushed
the
add_new_yast2ui_firewalld
branch
from
b68a7cd
to
ff173b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add new YaST2 UI firewalld: fate#324662:
Verify change of service status.
Verify change of default zone when the interface is assigned to default and when the interface is assigned to a different zone.
Add one service and one port.
Verify with firewall-cmd previous changes are applied.
Record corresponding soft-failures found: bsc#1114677 bsc#1114673 bsc#1114807
Related ticket: https://progress.opensuse.org/issues/42482
Needles:
opensuse needlessle needlesVerification run: