-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase default boot time #6149
Conversation
lib/opensusebasetest.pm
Outdated
|
||
if (check_var('ARCH', 'ppc64le')) { | ||
# give ppc another 120 seconds since it's slow sometimes | ||
$ready_time += 120; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see my comment on the progress ticket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we already have a bug for this? Then I would add a softfail
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DrMullings for the time being, you can use the progress ticket, unless somebody wants to validate manually how long the boot process takes on a ppc machine with suse-kvm with cryptsetup... I guess booting 3-5 times with correct password, and taking the time would do...
Please find a bugref or create a new bug to reference with a soft-fail. |
on s390x and ipmi we also have different timeouts without bugref, so my suggestion to improve this PR is to bump general readytime to 300 as our acceptible maximum time to boot a system (iirc it was 300 some time ago) |
We would need to communicate this very clearly to avoid new branches with higher timeouts then |
1fe1375
to
223484e
Compare
I have now increased the default wait time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your PR is still "WIP"?
lib/opensusebasetest.pm
Outdated
@@ -332,6 +332,7 @@ sub wait_boot { | |||
|
|||
# Reset the consoles after the reboot: there is no user logged in anywhere | |||
reset_consoles; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete
Setting the default wait time to 300 seconds to give slower archtitectures enough time
223484e
to
744c28c
Compare
Removed WIP, removed empty line, adapted description and header |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting two more minutes for grub to show up, if the test runs
on ppc64le