Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default boot time #6149

Merged
merged 1 commit into from
Jan 31, 2019
Merged

Increase default boot time #6149

merged 1 commit into from
Jan 31, 2019

Conversation

DrMullings
Copy link
Contributor

@DrMullings DrMullings commented Nov 7, 2018 •
edited
Loading

Waiting two more minutes for grub to show up, if the test runs
on ppc64le

foursixnine
foursixnine reviewed Nov 7, 2018
View reviewed changes
lib/opensusebasetest.pm Outdated

if (check_var('ARCH', 'ppc64le')) {
# give ppc another 120 seconds since it's slow sometimes
$ready_time += 120;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comment on the progress ticket

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have a bug for this? Then I would add a softfail

Copy link
Member

@foursixnine foursixnine Nov 8, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrMullings for the time being, you can use the progress ticket, unless somebody wants to validate manually how long the boot process takes on a ppc machine with suse-kvm with cryptsetup... I guess booting 3-5 times with correct password, and taking the time would do...

@okurz
Copy link
Member

okurz commented Jan 22, 2019

Please find a bugref or create a new bug to reference with a soft-fail.

@Soulofdestiny
Copy link
Contributor

Soulofdestiny commented Jan 24, 2019 •
edited
Loading

Please find a bugref or create a new bug to reference with a soft-fail.

on s390x and ipmi we also have different timeouts without bugref,
same in boot_to_desktop where we even distinguish between UEFI and non-UEFI with magic numbers, based on guesses - so I don't see why we should need a bsc here
to improve things, we could generally bump the timeout, because accepting the fastest architecture as worst-case doesn't make much sense to me.
And opening yet another bug which backfires to us with "check your hardware"-comments and never gets fixed is not the way to go here.

so my suggestion to improve this PR is to bump general readytime to 300 as our acceptible maximum time to boot a system (iirc it was 300 some time ago)

@DrMullings
Copy link
Contributor Author

so my suggestion to improve this PR is to bump general readytime to 300 as our acceptible maximum time to boot a system (iirc it was 300 some time ago)

We would need to communicate this very clearly to avoid new branches with higher timeouts then

@DrMullings
Copy link
Contributor Author

I have now increased the default wait time

okurz
okurz reviewed Jan 29, 2019
View reviewed changes
Copy link
Member

@okurz okurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your PR is still "WIP"?

lib/opensusebasetest.pm Outdated
@@ -332,6 +332,7 @@ sub wait_boot {

# Reset the consoles after the reboot: there is no user logged in anywhere
reset_consoles;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete

@DrMullings DrMullings changed the title [WIP] Increase wait time for boot on ppc64le Increase default boot time Jan 29, 2019
@DrMullings
Increase default wait time for boot
744c28c 
Setting the default wait time to 300 seconds to give slower
archtitectures enough time
@DrMullings
Copy link
Contributor Author

DrMullings commented Jan 29, 2019 •
edited
Loading

Removed WIP, removed empty line, adapted description and header

asdil12
asdil12 approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@asdil12 asdil12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asdil12 asdil12 merged commit 02a50a5 into os-autoinst:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foursixnine foursixnine foursixnine left review comments

@okurz okurz okurz left review comments

@asdil12 asdil12 asdil12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@DrMullings @okurz @Soulofdestiny @foursixnine @asdil12