Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix desktopapps-gnome for TW #6154

Merged
merged 1 commit into from
Nov 26, 2018
Merged

Fix desktopapps-gnome for TW #6154

merged 1 commit into from
Nov 26, 2018

Conversation

alapha23
Copy link
Contributor

@alapha23 alapha23 commented Nov 8, 2018

@alapha23 alapha23 force-pushed the desktopapps-gnome branch 2 times, most recently from d1ec225 to 469d321 Compare November 9, 2018 10:00
okurz
okurz reviewed Nov 10, 2018
View reviewed changes
tests/x11/gnomecase/change_password.pm Outdated
send_key "ret";
wait_still_screen;
type_string "$newpwd\n";
if (!is_tumbleweed) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our tests should always consider openSUSE Tumbleweed as the default product without a version. That means any differing behaviour should have an explicit exclude rule for the "older products" and potentially an explanation why the behaviour should differ. You can try to negate the logic check.

@alapha23
Copy link
Contributor Author

@okurz
I replaced the logic check with a meaningful one. What do you think?

@Soulofdestiny
Copy link
Contributor

@alapha23 Hey - I cannot reach the machine with your verification run :(

@alapha23
Copy link
Contributor Author

alapha23 commented Nov 26, 2018 •
edited
Loading

@Soulofdestiny
verification run http://10.67.18.219/tests/166

@Soulofdestiny Soulofdestiny merged commit e802b63 into os-autoinst:master Nov 26, 2018
@alapha23 alapha23 mentioned this pull request Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okurz okurz okurz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alapha23 @Soulofdestiny @okurz