Add test condition to remove libmicrohttpd test scenario in SLE15 #6435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitiao
reviewed
Dec 21, 2018
lib/main_common.pm
Outdated
| @@ -1979,8 +1979,8 @@ sub load_security_tests_web { | |||
| loadtest "console/wget_https"; | |||
| loadtest "console/w3m_https"; | |||
| loadtest "console/apache_ssl"; | |||
| if (check_var('DISTRI', 'sle') && get_var('FIPS_ENABLED')) { | |||
| loadtest "fips/mozilla_nss/apache_nssfips"; | |||
| loadtest "fips/mozilla_nss/apache_nssfips"; | |||
There was a problem hiding this comment.
apache_nssfips only works under fips mode
There was a problem hiding this comment.
Sorry my fault, How about changing like this simply
if (check_var('DISTRI', 'sle') && get_var('FIPS_ENABLED')) {
loadtest "fips/mozilla_nss/apache_nssfips";
}
if (is_sle('<15') && get_var('FIPS_ENABLED')) {
loadtest "console/libmicrohttpd";
}
There was a problem hiding this comment.
how about this
if (check_var('DISTRI', 'sle') && get_var('FIPS_ENABLED')) {
loadtest "fips/mozilla_nss/apache_nssfips";
loadtest "console/libmicrohttpd" if is_sle('<15');
}
There was a problem hiding this comment.
@mitiao Thanks for your suggestions,
I am just modifying a test like this , and I think your way is better 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test condition to remove libmicrohttpd test scenario in SLE15
The test was dropped from SLE15 but it will be still tested in SLE12-SPx
Related bsc#1087409
SLE15 : http://147.2.211.155/tests/180
SLE12SP4 : http://147.2.211.155/tests/181