Move keyboard selection to welcome #6492
Conversation
tests/installation/welcome.pm
Outdated
| @@ -16,7 +16,28 @@ use warnings; | |||
| use base "y2logsstep"; | |||
| use testapi; | |||
| use utils 'ensure_fullscreen'; | |||
| use version_utils qw(:VERSION :SCENARIO); | |||
| use version_utils qw(:VERSION :SCENARIO is_sle); | |||
There was a problem hiding this comment.
:VERSION tag should already import is_sle.
There was a problem hiding this comment.
cool, I didn't know we have this constant now. good to know.
There was a problem hiding this comment.
Code LGTM, but I'm still not sure if we should do that. I see the point, but separate module also have some advantages over having everything in a single place. So what's about at least making it more visible that we test keyboard layout with e.g. record_info calls?
jknphy
force-pushed
the
move_keyboard_sel_to_welcome
branch
from
9d48ecb
to
d8b7afa
Compare
|
Yes, that was my initial idea but I forgot at the end. Including it. thx. |
|
I like the idea of moving keyboard layout test to the welcome module. And also, I'm finding great to call record_info that allows to identify that the test is executed without checking openQA variables. LGTM. |
|
The only thing, I want to request is could you please execute verification run on migration job to sle15, on s390x Sle15, on Sle12 (any architecture). |
|
I was searching one by one in x86_64 and s390x column in Migration group for sle15 in case I could find some job where was scheduled |
|
@jknphy you could use an approach as in https://github.com/okurz/scripts/blob/master/openqa-db_query_last_use_of_module to find out where a module is running |
Move keyboard selection code to welcome test module to have all the tests related to that screen in one place.