Confirm unlocked screen for consoletest_finish #6603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinawang123
force-pushed
the
ConfirmUnlockScreen
branch
from
07b5d09
to
c115bd2
Compare
|
Please update the Copyright to 2015-2019. Others looks fine for me. |
tinawang123
force-pushed
the
ConfirmUnlockScreen
branch
from
c115bd2
to
9565af5
Compare
|
This fix looks fine for me. |
|
hm, just because I remember we had a lot of problems with ensure_unlocked_desktop I would have been more careful to merge this so fast without further validation. Let's see how it fares in production but I would appreciate if you can give a bit more time for review, especially for changes which are not limited to single scenarios but are used in many more jobs. |
|
Ok, Oliver, I got it. I will follow your suggestion to review more carefully before merge PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Confirm the screen is unlocked by some updated items
autoinst-log.txt