Fix "keymap_or_locale" on svirt backends which are not s390x-kvm #6642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psladek was not contributing in past years and is not reacting to tickets.
okurz
commented
Jan 25, 2019
| @@ -14,12 +14,12 @@ | |||
| # with this program; if not, see <http://www.gnu.org/licenses/>. | |||
|
|
|||
| # Summary: Log into system installed with autoyast | |||
| # Maintainer: Pavel Sladek <psladek@suse.cz> | |||
| # Maintainer: Oliver Kurz <okurz@suse.de> | |||
okurz
force-pushed
the
fix/keymap_poo46508
branch
2 times, most recently
from
ddbb329
to
16310d6
Compare
okurz
commented
Jan 25, 2019
We tried to distinguish by "is_remote_backend" if there is a "tty" where we can try out the keymap without being logged in or if we need to use a "logged in terminal", e.g. a ssh session. However some backends which we consider "remote" still do offer ttys: The svirt backends provide a complete remote control of the VM instances including ttys with the notable exception of s390x KVM which calls itself "svirt" itself but does not provide the ttys. Hence this commit introduces another explicit backend check function which we can use in the "keymap_or_locale" test module. See for example: * https://openqa.suse.de/tests/2401420#step/keymap_or_locale/2 on "svirt-hyperv" failing because we expect a cleared console but we do have a tty which was unexpected * https://openqa.suse.de/tests/2401211#step/keymap_or_locale/3 on s390x-kvm where there is no tty but a terminal session provided by ssh * https://openqa.suse.de/tests/2401491#step/keymap_or_locale/3 on the standard qemu backend showing the tty Related progress issue: https://progress.opensuse.org/issues/46508
okurz
force-pushed
the
fix/keymap_poo46508
branch
from
16310d6
to
3468b7d
Compare
|
all jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We tried to distinguish by "is_remote_backend" if there is a "tty" where
we can try out the keymap without being logged in or if we need to use a
"logged in terminal", e.g. a ssh session. However some backends which we
consider "remote" still do offer ttys: The svirt backends provide a complete
remote control of the VM instances including ttys with the notable exception
of s390x KVM which calls itself "svirt" itself but does not provide the ttys.
Hence this commit introduces another explicit backend check function which
we can use in the "keymap_or_locale" test module.
See for example:
"svirt-hyperv" failing because we expect a cleared console but we do have
a tty which was unexpected
where there is no tty but a terminal session provided by ssh
standard qemu backend showing the tty
Verification runs:
Created job #2404376: sle-15-SP1-Installer-DVD-x86_64-Build149.2-default@svirt-hyperv -> https://openqa.suse.de/t2404376
Created job #2404377: sle-15-SP1-Installer-DVD-s390x-Build149.2-textmode@s390x-kvm-sle12 -> https://openqa.suse.de/t2404377
Created job #2404379: sle-15-SP1-Installer-DVD-x86_64-Build149.2-textmode@64bit -> https://openqa.suse.de/t2404379
Related progress issue: https://progress.opensuse.org/issues/46508