[WIP] Ensure unlocked desktop #6729
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SergioAtSUSE
commented
Feb 6, 2019
SergioAtSUSE
commented
- Related ticket: https://progress.opensuse.org/issues/45710
- Verification run: http://openqa.slindomansilla-vm.qa.suse.de/tests/1219
SergioAtSUSE
force-pushed
the
ensure_unlocked_desktop
branch
from
dff040e
to
8929826
Compare
okurz
reviewed
Feb 7, 2019
lib/x11utils.pm
Outdated
| # if stay under tty console for long time, then check | ||
| # screen lock is necessary when switch back to x11 | ||
| # all possible options should be handled within loop to get unlocked desktop | ||
| # When there is an application openede, generic-desktop won't match, | ||
| # you can pass the tag name as parameter C<$needle_tag> to match that open application |
There was a problem hiding this comment.
When turning into pod please remove the leading #. Also typo in openede
lib/x11utils.pm
Outdated
| sub ensure_unlocked_desktop { | ||
| my $needle_tag = shift @_; |
There was a problem hiding this comment.
Would you mind using my ($needle_tag) = @_; ?
| @@ -35,6 +36,7 @@ sub run { | |||
| # needle cannot match so we rely on the assert_and_click from | |||
| # connect_to_network | |||
| select_console 'x11', await_console => 0; | |||
| ensure_unlocked_desktop; | |||
There was a problem hiding this comment.
Don't you want to call it with the parameter here?
|
We just type a few lines within a minute and return to the x11 session. The session shouldn't even be locked. And I doubt it's a good idea we sprinkle in seemingly random "ensure_unlocked_desktop" everywhere. Seems you have missed all my suggestions in the ticket description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.