Get rid of wait_still_screen calls #6792
Conversation
mloviska
commented
Feb 14, 2019
•
mloviska
commented
- Pre-requisite: Extend arguments for type_string #1106
- Related ticket: [functional][y] Reduce waiting timeout in yast2_hostnames while cursor is blinking
- Needles:
- OSD
- o3
- Verification runs:
- sle-12-SP5-Server-DVD-x86_64-Build0122-yast2_gui@64bit
- sle-15-SP1-Installer-DVD-x86_64-Build162.2-yast2_gui@64bit
- opensuse-15.1-DVD-x86_64-Build411.4-yast2_gui@64bit
- opensuse-Tumbleweed-DVD-x86_64-Build20190209-yast2_gui@64bit
- Failure
|
I've added notready label, so we don't merge it accidentally. |
mloviska
force-pushed
the
y2_hostnames_to
branch
from
5fba181
to
e0c76ad
Compare
|
os-autoinst/os-autoinst#1106 got merged! |
|
both needles PR merged |
|
|
||
| my $self = shift; | ||
| my $module = "host"; | ||
| my $dm = lc get_var('DESKTOP'); |
There was a problem hiding this comment.
care to use get_required_var instead?
There was a problem hiding this comment.
oh, I have forgotten about this subroutine. Ty!
| send_key 'tab'; | ||
| type_string($hosts_params->{fqdn}, max_interval => 13, wait_still_screen => 0.05, timeout => 5, similarity_level => 38); | ||
| send_key 'tab'; | ||
| type_string($hosts_params->{alias}, max_interval => 13, wait_still_screen => 0.05, timeout => 5, similarity_level => 38); |
There was a problem hiding this comment.
What's about having some wrapper with given set of parameters, as I guess they were derived empirically?
There was a problem hiding this comment.
Do you mean to put all empirical values under one data structure? Or do you suggest to somehow wrap them into a subroutine?
There was a problem hiding this comment.
I guess more like second, so similarly to type_string_slow and type_string_very_slow. WDYT?
There was a problem hiding this comment.
So, to resolve this one, what do you think about some wrapper? If you object, I'm fine to leave it as is, but I'm quite sure that this will be handy in many other scenarios.
There was a problem hiding this comment.
Sorry for the delay. I will deliver the update during the day.
There was a problem hiding this comment.
are you ok to leave the wrapper for now in the test module code? I am not sure if I have set the values correctly for OSD or O3. I am expecting some minor updates after the code gets merged.
There was a problem hiding this comment.
Sure, fine with me. Let's merge then ;)
There was a problem hiding this comment.
ah, I have pushed the updates a few minutes after the PR got merged. ups...
There was a problem hiding this comment.
I've misunderstood you. But no worries, create new PR ;)
|
os-autoinst changes were deployed, so we can proceed with this one |
|
Breaks various gnome tests, like: https://openqa.opensuse.org/tests/873148# the same is observed in stagings, out of stagings, on Leap and on Tumbleweed (@nilxam - this should be the same for your leap issues) |
|
@mloviska is not available on irc, so I will revert and retrigger the jobs which I will be able to find |
|
Propsal fix - without having to revert all of it: #6987 |
