Add autoyast keyboard layout test #6833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jknphy
changed the title
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
586dd80
to
ea76776
Compare
jknphy
changed the title
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
ea76776
to
5e50289
Compare
rwx788
reviewed
Feb 19, 2019
rwx788
reviewed
Feb 19, 2019
rwx788
reviewed
Feb 19, 2019
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
5e50289
to
888aa94
Compare
rwx788
reviewed
Feb 19, 2019
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
888aa94
to
f679ee8
Compare
jknphy
changed the title
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
2 times, most recently
from
7361dd7
to
534fe66
Compare
jknphy
changed the title
|
All suggestions addressed. |
|
Don't merge before the needles are merged |
rwx788
reviewed
Feb 20, 2019
tests/locale/keymap_or_locale.pm
Outdated
|
|
||
| if (check_var('DESKTOP', 'textmode')) { | ||
| assert_screen([qw(linux-login cleared-console)]); | ||
| verify_default_keymap_textmode($keystrokes, "${expected}_keymap"); | ||
| return if verify_default_keymap_textmode($keystrokes, "${expected}_keymap"); |
There was a problem hiding this comment.
I'm not sure if this is clear, this condition is weird to me. I would split the method into two and make it explicit that if it's us we don't run further checks.
There was a problem hiding this comment.
I created a function for that to make it more clear. VR updated.
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
534fe66
to
b439eb8
Compare
jknphy
force-pushed
the
add_autoyast_keyboard_layout_test
branch
from
b439eb8
to
eb4ddf1
Compare
rwx788
reviewed
Feb 20, 2019
|
I was not able to merge needles, because gitlab is down, so please, do not enable test suite yet =) |
|
For me is up, should I merge them myself? |
|
@jknphy , please, do so. I've checked those needles and they are fine ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add autoyast keyboard layout test
Requires new test suite
autoyast_keyboard_layoutsimilar toautoyast_miniexcept for the following params:AUTOYAST=autoyast_sle15/autoyast_keyboard_layout.xmlINSTALL_KEYBOARD_LAYOUT=czAUTOYAST_CONFIRM=