Grep systemd target in installation_overview #6977
Conversation
JRivrain
force-pushed
the
inst_overview
branch
4 times, most recently
from
0e051de
to
d918708
Compare
JRivrain
changed the title
JRivrain
force-pushed
the
inst_overview
branch
4 times, most recently
from
e9ecf94
to
58435c2
Compare
JRivrain
changed the title
JRivrain
force-pushed
the
inst_overview
branch
9 times, most recently
from
b6bb310
to
56e9e85
Compare
JRivrain
force-pushed
the
inst_overview
branch
2 times, most recently
from
7c71df3
to
782ccdf
Compare
JRivrain
changed the title
|
os-autoinst/os-autoinst-needles-opensuse#527 has not been merged. |
|
My bad, I always forget to merge needles =(. |
|
Well, one problem was the needle, another was that in some cases it fails on kubic. We have to exclude it also on kubic. I created the new PR, but will do extra testing just in case. One very annoying thing is I had tried to find all the possible cases by searching for needles matching installation-settings-overview-loaded in https://openqa.opensuse.org/admin/needles, but those kubics tests did not come up. So I don't see any way to predict what will fail, except to test the hundreds of single SUTs out there ? |
|
I'm with @rwx788 than in previous comments mentioned to write that piece of code in a different module, but perhaps you have already found most of the cases to not opt for that at this point. |
Yeah, that's what we have to deal with, which is understandably frustrating. As for finding potential failures, you can use feature implemented by @OleksandrOrlov to look for test modules. But for this particular one, I guess it's in most of scenarios, including textmode for some maintenance, etc. To play it safe we could make it in two iterations, to have some way to detect all usages (e.g. check_screen) and on second iteration make it strict to fail when SUT doesn't match expectations. Alternative would be to create separate module and enable it for only known scenarios, which means messing with main.pm. |
We want to verify if the right systemd target is activated at the earliest possible stage.
http://amazing.suse.cz/tests/3958 (graphical, sle12sp5)
http://amazing.suse.cz/tests/3957 (text, sle15sp1)
http://amazing.suse.cz/tests/3956 (graphical xfce, tumbleweed)
Also tested on some exotic production cases
https://openqa.suse.de/tests/2537187 (text, xen)
https://openqa.suse.de/tests/2537189 (graphical)
https://openqa.suse.de/tests/2537188 (graphical, IPMI)
https://openqa.suse.de/tests/2558476 (graphical, s390x-kvm-sle12)
https://openqa.suse.de/tests/2562376 (texmode, s390x-zVM-ctc)
https://openqa.suse.de/tests/2565581 (excluded for hyperv)