Extend rt validation test #7113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwx788
reviewed
Mar 21, 2019
|
|
||
| sub run { | ||
| my $self = shift; | ||
| select_console 'root-console'; | ||
| ensure_serialdev_permissions; |
There was a problem hiding this comment.
We already call it in tests/console/system_prepare, why do we need to call it again?
There was a problem hiding this comment.
http://eris.suse.cz/tests/12563#step/aplay/23
This happened even after I have removed reset_consoles in kmp_modules.pm
mloviska
commented
Mar 21, 2019
|
All the points has been addressed. I will merge it. |
|
@jknphy ty! I will do the clean up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to stability issues, I have excluded sshd, kdump_and_crash, yast2_bootloader for now
Note: After merging this PR, RT_TESTS openQA variable should be removed from rt-validation_extra_tests test suite