Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix record_info in installation_overview #7140

Merged
merged 1 commit into from Mar 25, 2019
Merged

Fix record_info in installation_overview #7140

merged 1 commit into from Mar 25, 2019

Conversation

JRivrain
Copy link
Contributor

@JRivrain JRivrain force-pushed the installation_overview branch 3 times, most recently from ed38da3 to fbe3484 Compare March 25, 2019 11:04
@JRivrain JRivrain force-pushed the installation_overview branch 2 times, most recently from 1675fc3 to a110caa Compare March 25, 2019 12:45
@JRivrain
Fix record_info
48735f8 
Exclude also ssh and vnc installs
@jknphy
Copy link
Contributor

jknphy commented Mar 25, 2019

LGTM, just paste one VR and remove [WIP] when you think is ready.

@JRivrain
Copy link
Contributor Author

VR for the message box: https://openqa.suse.de/tests/2728532#step/installation_overview/28.
I could not do VRs for the exclusion of REMOTE_CONTROLLER, they all finish as incomplete. On production I get an infinite loop in remote_controller": "mutex lock 'installation_ready' unavailable, sleeping 5s" and locally I get a "can't open qmp"

@JRivrain JRivrain changed the title [WIP]Fix record_info Fix record_info Mar 25, 2019
@jknphy jknphy changed the title Fix record_info Fix record_info in installation_overview Mar 25, 2019
@jknphy
Copy link
Contributor

jknphy commented Mar 25, 2019

The problem you show me in https://openqa.suse.de/tests/2729381 I think is some issues with parallel jobs in the VR when you use openqa-clone-custom-git-refspec. I retriggered in prod and remote_controller module is reached: https://openqa.suse.de/tests/2730285#step/remote_controller/22 so we can discard external things.

@jknphy
Copy link
Contributor

jknphy commented Mar 25, 2019

Let's merge it with the improvement and we can investigate in future how openqa-clone-custom-git-refspec behaves with parallel jobs.

@jknphy jknphy merged commit 7ea5d9b into os-autoinst:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jknphy jknphy jknphy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@JRivrain @jknphy