Introduce nested limit checks #7519
Conversation
|
the Travis now is failing because of the introduced nested limits. |
b10n1k
force-pushed
the
poo48605
branch
3 times, most recently
from
a3fde16
to
9456c2a
Compare
There was a problem hiding this comment.
It actually fails with following errors:
tests/migration/sle12_online_migration/yast2_migration.pm: Code structure is deeply nested at line 159, column 21. Consider refactoring. (Severity: 4)
tests/slenkins/slenkins_control.pm: Code structure is deeply nested at line 84, column 21. Consider refactoring. (Severity: 4)
|
those are modules that should be assigned to the corresponding teams to take care of. i didnt make anything with them. @rwx788 do you want me to fix those? |
|
Hi @b10n1k, I guess fixing these issues yourself is actually easier than waiting for someone else. For the "slenkins" file I am sure there is no other "team" currently that would feel better responsible. However, there would also be the alternative to exclude these two files explicitly from the checks. That sounds a bit messy though ;) |
b10n1k
force-pushed
the
poo48605
branch
7 times, most recently
from
11aa4ce
to
5352bb3
Compare
|
|
||
| [ControlStructures::ProhibitDeepNests] | ||
| severity = 4 | ||
| add_themes = freenode |
There was a problem hiding this comment.
Good catch here, according to documentation, add_themes makes more sense than set_themes even we could see same output.
|
LGTM |
Update .perlcriticrc to run nested limit checks and fixed issue for lib/registration.pm
and http://aquarius.suse.cz/tests/949 shows that changes are not destructive