xorg_vt: Generalize needle tag to cover any tty #7769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the needle stated the assumption that we would be on tty7 however this has not been true for quite some time on many systems already so let's generalize. Needs os-autoinst/os-autoinst-needles-opensuse#565 Related progress issue: https://progress.opensuse.org/issues/53339
DimStar77
approved these changes
Jul 2, 2019
|
Why would you use needle in console ? https://openqa.suse.de/tests/3024380#step/xorg_vt/4 |
|
@dzedro why don't you fix the world today? – As a wise man once said: Sorry, I have only two clumsy hands myself ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the needle stated the assumption that we would be on tty7
however this has not been true for quite some time on many systems
already so let's generalize.
Needs os-autoinst/os-autoinst-needles-opensuse#565
Related progress issue: https://progress.opensuse.org/issues/53339